Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error: S cannot be shared between threads safely #127

Closed
hackel opened this issue Jan 24, 2022 · 1 comment
Closed

Compilation error: S cannot be shared between threads safely #127

hackel opened this issue Jan 24, 2022 · 1 comment

Comments

@hackel
Copy link

hackel commented Jan 24, 2022

I got this after just adding presage to a new test project. I didn't even start trying to use the code and compilation fails:

error[e0277]: `s` cannot be shared between threads safely
   --> /home/hackel/dev/presage-test/_build/cargo-home/git/checkouts/libsignal-service-rs-e91a0c40cab55da9/91d7d09/libsignal-service/src/sender.rs:486:30
    |
486 | ...                   .delete_service_addr_device_session(
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `s` cannot be shared between threads safely
    |
note: required by a bound in `sessionstoreext::delete_service_addr_device_session`
   --> /home/hackel/dev/presage-test/_build/cargo-home/git/checkouts/libsignal-service-rs-e91a0c40cab55da9/91d7d09/libsignal-service/src/session_store.rs:33:14
    |
33  |     async fn delete_service_addr_device_session(
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `sessionstoreext::delete_service_addr_device_session`
help: consider further restricting this bound
    |
130 |     s: sessionstore + sessionstoreext + clone + std::marker::sync,
    |                                               +++++++++++++++++++

error[e0277]: `s` cannot be shared between threads safely
   --> /home/hackel/dev/presage-test/_build/cargo-home/git/checkouts/libsignal-service-rs-e91a0c40cab55da9/91d7d09/libsignal-service/src/sender.rs:532:30
    |
532 | ...                   .delete_service_addr_device_session(
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `s` cannot be shared between threads safely
    |
note: required by a bound in `sessionstoreext::delete_service_addr_device_session`
   --> /home/hackel/dev/presage-test/_build/cargo-home/git/checkouts/libsignal-service-rs-e91a0c40cab55da9/91d7d09/libsignal-service/src/session_store.rs:33:14
    |
33  |     async fn delete_service_addr_device_session(
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `sessionstoreext::delete_service_addr_device_session`
help: consider further restricting this bound
    |
130 |     s: sessionstore + sessionstoreext + clone + std::marker::sync,
    |                                               +++++++++++++++++++

rustc 1.58.1 (db9d1b20b 2022-01-20)

@gferon
Copy link
Collaborator

gferon commented Jan 24, 2022

Yeah, we broke the build which should get fixed when #125 gets merged. I'll also make sure presage builds against a specific commit of downstream libs from git so that it doesn't happen again in the future!

@hackel hackel closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants