Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection of changed safety number #181

Closed
langfingaz opened this issue Jul 28, 2023 · 2 comments · Fixed by #206
Closed

Detection of changed safety number #181

langfingaz opened this issue Jul 28, 2023 · 2 comments · Fixed by #206
Milestone

Comments

@langfingaz
Copy link

Hi, I'm a user of Flare which uses this library. Many thanks for creating it!

If a user installs installs their main Signal client on a new phone (or re-installs it on the same phone), the official Signal clients display this message in chats with that person:

Your safety number with ... has changed. Learn more.

Do you know, if it is already possible to detect a changed safety number of a user with presage without sending a message to that user?

This would enable applications such as Flare to inform users about changed safety numbers of chat opponents. At the moment, Flare displays an error when trying to send a message in that case (ProtocolError, UntrustedIdentity) - so this is already better than silently ignoring changed security keys completely, but definitely not ideal ;)

@langfingaz langfingaz changed the title Changed safety number Detection of changed safety number Jul 28, 2023
@gferon
Copy link
Collaborator

gferon commented Aug 31, 2023

I believe it is possible, yes, but I'm not sure what the best API to report such a change would be. I'll add this issue to the next milestone 🧱

@gferon gferon added this to the 0.6.0 milestone Aug 31, 2023
@gferon
Copy link
Collaborator

gferon commented Nov 19, 2023

I believe this was addressed in #206

@gferon gferon closed this as completed Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants