Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATH-like variable modifications overwrite instead of union in saves #2

Closed
whisperity opened this issue Oct 16, 2019 · 1 comment
Closed
Labels
bug 🪲 Something isn't working core 💥 Envprobe core
Milestone

Comments

@whisperity
Copy link
Owner

Reproduce:

  1. ep +PATH foo
  2. ep save foo
  3. ep +PATH bar
  4. ep save foo
  5. cat ~/.local/share/envprobe/saves/foo.json

Results in the following save:

{
  "unset": [],
  "variables": {
    "PATH": {
      "add": [
        "/tmp/bar"
      ],
      "remove": []
    }
  }

The addition of directory foo to the variable is missing.

@whisperity whisperity added bug 🪲 Something isn't working core 💥 Envprobe core labels Oct 16, 2019
@whisperity whisperity added this to the V1.1 release milestone Dec 26, 2020
@whisperity whisperity modified the milestones: V1.1 release, V1 release Mar 27, 2021
@whisperity
Copy link
Owner Author

envvar has been extended with apply_diff and merge_diff on the interface, lowering the responsibility into the typeclass instead of the save and load commands, which now use these methods to properly "concatenate" changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working core 💥 Envprobe core
Projects
None yet
Development

No branches or pull requests

1 participant