Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the state being sent? #12

Closed
bleepsandblops opened this issue Apr 3, 2023 · 1 comment · Fixed by #13
Closed

Is the state being sent? #12

bleepsandblops opened this issue Apr 3, 2023 · 1 comment · Fixed by #13
Assignees
@WHITE-developer
Labels
bug Something isn't working

Comments

@bleepsandblops
Copy link
Contributor

Description

It looks like you're not sending the address state to Sendcloud (for example in the US, 'Illinois'):
https://github.com/white-nl/commerce-sendcloud/blob/v2/src/client/JouwWebSendcloudAdapter.php#L228

Steps to reproduce

  1. Create an order with a US address
  2. The order goes through to sendcloud with an empty state and can't proceed further

Additional info

  • Craft version: 4.4.2
  • Commerce: 4.2.4
  • PHP version: 8.1
  • Database driver & version:
  • Plugins & versions: Sendcloud 2.1.2
@bleepsandblops bleepsandblops added the bug Something isn't working label Apr 3, 2023
@bleepsandblops bleepsandblops changed the title Is the state missing? Is the state being sent? Apr 3, 2023
@bleepsandblops bleepsandblops mentioned this issue Apr 3, 2023
Merged
@WHITE-developer
Copy link
Collaborator

Thanks for the PR @bleepsandblops.
merged and tagged 2.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WHITE-developer WHITE-developer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding AdministrativeArea field to the address being sent bleepsandblops/commerce-sendcloud
2 participants
@bleepsandblops @WHITE-developer