Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API sorts reports by oldest first #129

Merged
merged 2 commits into from
Feb 12, 2023
Merged

API sorts reports by oldest first #129

merged 2 commits into from
Feb 12, 2023

Conversation

sinnec
Copy link
Contributor

@sinnec sinnec commented Feb 10, 2023

No description provided.

NickNtamp
NickNtamp suggested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@NickNtamp NickNtamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinnec I think that descending is not the desired order if I am not mistaken. We want the oldest report to be on the top of the list. Can you please recheck it and confirm?

@sinnec
Copy link
Contributor Author

sinnec commented Feb 10, 2023 •
edited

@sinnec I think that descending is not the desired order if I am not mistaken. We want the oldest report to be on the top of the list. Can you please recheck it and confirm?

Yes, your're right. I thought it should be latest first.

@sinnec sinnec changed the title API sorts reports by latest first API sorts reports by oldest first Feb 10, 2023
@NickNtamp NickNtamp merged commit d1d7618 into main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momegas momegas momegas approved these changes

@NickNtamp NickNtamp NickNtamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sinnec @momegas @NickNtamp