Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova translations for tool lines #23

Open
alex-osborn opened this issue Mar 9, 2019 · 1 comment
Open

Nova translations for tool lines #23

alex-osborn opened this issue Mar 9, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@alex-osborn
Copy link

Great work with the package.

Currently the Nova tool label can be customised with config('novapage.label').

However, other strings in the tool are hard-coded and cannot be updated.

Screen Shot 2019-03-09 at 4 14 29 PM

Most of these could be run through translations to allow this, such as changing Whitecube\NovaPage\Pages\Resource::singularLabel()

    /**
     * Get the displayable singular label of the resource.
     *
     * @return string
     */
    public static function singularLabel()
    {
        return 'nova-page';
    }
    /**
     * Get the displayable singular label of the resource.
     *
     * @return string
     */
    public static function singularLabel()
    {
        return __('nova-page');
    }
@toonvandenbos
Copy link
Member

Hi @alex-osborn,

Yep, you're right. We'll update those soon :)

@toonvandenbos toonvandenbos added the enhancement New feature or request label Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants