Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2.3] Deleting non-top left part of loop controller causes error "Cannot delete special object flag tiles" on further deletes there #276

Closed
hsandt opened this issue Jun 12, 2022 · 1 comment
Labels
Bug - Class C Collision bugs, editor GUI problems, enemies misbehave, etc

Comments

@hsandt
Copy link

hsandt commented Jun 12, 2022

Reproduction steps:

  1. Add a loop controller from Items and Gimmicks ("Simple Mode" in the Manual)
  2. Select any tile from Tiles (to enable tile deletion again) and delete any quarter of the loop except the top-left quarter (which deletes the whole loop properly) => only the quarter is removed.
  3. Keep holding the delete button (right-mouse button or E) hovering the surroundings => an error message "Cannot delete special object flag tiles" with error SFX is spammed.

Deleting non-top left part of loop controller causes Cannot delete special object flag tiles

  1. Delete the top-left part. This time, all "flag tiles" have been cleaned, and the error stops spamming.

Note: I initially got a different bug, a crash that I couldn't reproduce. After adding a bunch of tiles, a loop controller on top, then deleting tiles on the loop and around, I got:

############################################################################################
ERROR in
action number 1
of Step Event0
for object obj_loop_logic:

Tile does not exist.
at gml_Object_obj_loop_logic_Step_0
############################################################################################

stack frame is
gml_Object_obj_loop_logic_Step_0 (line -1)

But since I couldn't reproduce it even once, I could not define precise repro steps so I didn't open a ticket about that. However, I could at least spot the "flag tiles" error instead, so posting this one instead.

@whitelilydragon whitelilydragon added the Bug - Class C Collision bugs, editor GUI problems, enemies misbehave, etc label Jun 13, 2022
@whitelilydragon
Copy link
Owner

While I do appreciate that you were able to reproduce the problem, I encourage you to update the version you're playing! 1.0.2.3 is nearly a year out of date; it's missing everything from the inclusion of Spade, Carrie, another alt skin for Milla, mouse support for player mode, better analog stick support, more tile sets and backgrounds, more gimmicks, and other quality of life features for the editor itself-

And just today, I decided to move one of the rolling builds to the "stable" downloads channel. The instances of confusion over which version to download are becoming too many, and I believe the latest rolling build has enough bug fixes and QoL to be a worthy update.

That said, the crashing issue should have been addressed in the latest updates! But I found an efficient way for the loop controller to check whether or not all of its tiles exist, and it will now delete itself if one or more pieces go missing. You will see that fix in version 1.0.8.8 in the releases section of this GitHub page!

https://github.com/whitelilydragon/ShangMuArchitect/releases/tag/v1.0.8.8

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug - Class C Collision bugs, editor GUI problems, enemies misbehave, etc
Projects
None yet
Development

No branches or pull requests

2 participants