Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vulture linter #21

Merged
merged 7 commits into from Jun 18, 2021
Merged

Add vulture linter #21

merged 7 commits into from Jun 18, 2021

Conversation

marcofavorito
Copy link
Member

Proposed changes

Add vulture linter.

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #21 (ae620c6) into release (7a130a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release      #21   +/-   ##
========================================
  Coverage    90.42%   90.42%           
========================================
  Files           16       16           
  Lines          710      710           
  Branches        59       59           
========================================
  Hits           642      642           
  Misses          53       53           
  Partials        15       15           
Flag Coverage Δ
unittests 90.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@francescofuggitti francescofuggitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcofavorito marcofavorito merged commit 3d28b15 into release Jun 18, 2021
@marcofavorito marcofavorito deleted the vulture branch June 18, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants