Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

Fix a memory size exhausted error for some PHP versions in Travis CI #137

Closed
wants to merge 2 commits into from

Conversation

bocharsky-bw
Copy link
Contributor

However, this does not solve the problem with Allowed memory size exhausted in Travis...

@sampart
Copy link
Owner

sampart commented Feb 16, 2016

Hi @bocharsky-bw, thanks for the PR. It looks like your changes are coming up against this problem, though: travis-ci/travis-ci#3930

@bocharsky-bw
Copy link
Contributor Author

Hey @sampart , there's also a workaround that helps don't use phpenv for HHWV... But, actually, I want to fix error related with memory limit:

PHP Fatal error:  Allowed memory size of 1073741824 bytes exhausted (tried to allocate 71 bytes) in phar:///home/travis/.phpenv/versions/5.3.29/bin/composer/src/Composer/DependencyResolver/RuleWatchGraph.php on line 47

see https://travis-ci.org/whiteoctober/WhiteOctoberPagerfantaBundle/jobs/108745537 .

However, my PR don't solve this properly and I haven't any idea how to fix this error.

@bocharsky-bw bocharsky-bw changed the title Disable XDebug to increase performance Fix a memory size exhausted error for some PHP versions in Travis CI Feb 16, 2016
@sampart
Copy link
Owner

sampart commented Feb 16, 2016

@bocharsky-bw Ah okay, I see your point. You're fixing the memory errors in PHP 5.3 with this.

However, as your PR introduces a new issue with HHVM, I'm reluctant to merge it. If you could update the PR so that the phpenv issue in HHVM is resolved then I will merge it - although the HHVM memory issue will still exist at that point, the total number of errors will be reduced!

@bocharsky-bw
Copy link
Contributor Author

@sampart I fixed failure for HHVM... but we still have a failure for PHP 5.3.

@bocharsky-bw
Copy link
Contributor Author

@sampart I temporarily allowed failures for PHP 5.3 due to memory limit error. What do you think? If it's OK I'm going to squash my commits.

@sampart
Copy link
Owner

sampart commented Feb 22, 2016

Thanks for the comments to fix HHVM's complaints, @bocharsky-bw. That's great.

Please can you remove the allow_failures for PHP 5.3? I'd rather have that continue to fail until we've fixed it, as that'll then be a reminder that this issue still exists. Otherwise the issue will get forgotten!

If you could remove that and squash the commits, then we should be ready to go!

@bocharsky-bw
Copy link
Contributor Author

@sampart Removed allow_failures and squashed commits.

@sampart
Copy link
Owner

sampart commented Feb 22, 2016

Thanks for this. Looking afresh at the code reminds me that I meant to ask you - do we really need to allow PHP an unlimited amount of memory? That seems a bit extreme. It seems that removing xdebug is enough to get this working on HHVM, and unlimited memory for PHP doesn't help on 5.3 anyway, so I'm wondering whether that change can be removed?

@@ -27,6 +27,8 @@ cache:
- $HOME/.composer/cache/files

before_install:
- if [[ "$TRAVIS_PHP_VERSION" != "hhvm" ]]; then phpenv config-rm xdebug.ini; fi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment above here explaining that hhvm doesn't support phpenv? Otherwise it's not obvious why the if statement is there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure! Added.

@pablodip
Copy link
Contributor

Done in #144

@pablodip pablodip closed this Mar 16, 2016
@bocharsky-bw bocharsky-bw deleted the patch-1 branch March 16, 2016 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants