-
Notifications
You must be signed in to change notification settings - Fork 109
Fix a memory size exhausted error for some PHP versions in Travis CI #137
Conversation
Hi @bocharsky-bw, thanks for the PR. It looks like your changes are coming up against this problem, though: travis-ci/travis-ci#3930 |
Hey @sampart , there's also a workaround that helps don't use
see https://travis-ci.org/whiteoctober/WhiteOctoberPagerfantaBundle/jobs/108745537 . However, my PR don't solve this properly and I haven't any idea how to fix this error. |
@bocharsky-bw Ah okay, I see your point. You're fixing the memory errors in PHP 5.3 with this. However, as your PR introduces a new issue with HHVM, I'm reluctant to merge it. If you could update the PR so that the |
@sampart I fixed failure for HHVM... but we still have a failure for PHP 5.3. |
@sampart I temporarily allowed failures for PHP 5.3 due to memory limit error. What do you think? If it's OK I'm going to squash my commits. |
Thanks for the comments to fix HHVM's complaints, @bocharsky-bw. That's great. Please can you remove the If you could remove that and squash the commits, then we should be ready to go! |
5ca8180
to
a8e21d4
Compare
@sampart Removed |
Thanks for this. Looking afresh at the code reminds me that I meant to ask you - do we really need to allow PHP an unlimited amount of memory? That seems a bit extreme. It seems that removing xdebug is enough to get this working on HHVM, and unlimited memory for PHP doesn't help on 5.3 anyway, so I'm wondering whether that change can be removed? |
@@ -27,6 +27,8 @@ cache: | |||
- $HOME/.composer/cache/files | |||
|
|||
before_install: | |||
- if [[ "$TRAVIS_PHP_VERSION" != "hhvm" ]]; then phpenv config-rm xdebug.ini; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment above here explaining that hhvm doesn't support phpenv
? Otherwise it's not obvious why the if statement is there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure! Added.
Done in #144 |
However, this does not solve the problem with
Allowed memory size exhausted
in Travis...