Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

Add swahili translation #207

Merged
merged 4 commits into from Nov 7, 2018
Merged

Conversation

m453h
Copy link
Contributor

@m453h m453h commented Nov 6, 2018

Add Swahili Translation, Swahili is a lingua franca of the African Great Lakes region and other parts of eastern and south-eastern Africa, including Tanzania, Kenya, Uganda, Rwanda, Burundi, Mozambique, and the Democratic Republic of the Congo (DRC).

This will greatly benefit numerous developers that want to build multi-lingual websites that support the Swahili Language.

Copy link
Owner

@sampart sampart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing, @m453h! I really appreciate it. I've got a couple of comments.

</trans-unit>
</body>
</file>
</xliff>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add a linebreak here to keep git happy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added the line-break,I hope its all good

<body>
<trans-unit id="1">
<source>previous</source>
<target>Nyumba</target>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take the precaution of running community-suggested translations through Google translate just in case someone decides to troll us by putting in offensive translations in PRs. I'm sure your Swahili is better than Google's, so I hope you don't mind me checking, but Google and Wiktionary both give the English translation of Nyumba as "House" (and suggest other words for "next"). Please could you just confirm that it is correct? I'm happy to take your word for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work for the precaution, just cross checked had a typo, very sorry for that ...its rather "Nyuma" instead of "Nyumba", just made the changes I hope everything is fine now :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @m453h. Glad I checked!

@sampart sampart merged commit 69604d0 into sampart:master Nov 7, 2018
@sampart
Copy link
Owner

sampart commented Nov 7, 2018

Thanks again for your input here. I've merged it as you'll see. Do you need a release making for this?

@sampart
Copy link
Owner

sampart commented Jan 10, 2019

@m453h m453h deleted the add_swahili_translation branch February 1, 2019 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants