Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

Switch to namespaced Twig classes #214

Merged
merged 2 commits into from Nov 21, 2019
Merged

Switch to namespaced Twig classes #214

merged 2 commits into from Nov 21, 2019

Conversation

mynameisbogdan
Copy link
Contributor

Hello,

I think it's due switching to Twig's namespaced classes in order to support next versions of Twig/Symfony.

https://symfony.com/blog/new-in-twig-namespaced-classes

@sampart
Copy link
Owner

sampart commented Nov 20, 2019

Hi @mynameisbogdan, thanks for contributing!

Please could you check which versions of Twig/Symfony are required for this to work and include any necessary changes to composer.json in this PR (or confirm that this code will work with all the versions matching the rules in composer.json). Thanks!

@mynameisbogdan
Copy link
Contributor Author

Hello @sampart!

I just bumped the PHP minimum version to 5.3.3, and also for Twig to 1.34 which is the first release to introduce namespaces.

Also, travis builds for this repo doesn't seem to works?

@sampart sampart merged commit f492615 into sampart:master Nov 21, 2019
@sampart
Copy link
Owner

sampart commented Nov 21, 2019

Thanks for this, @mynameisbogdan, that's great. I've merged it now, and created a release.

Yes, you're right about Travis. However, as this project is not actively maintained, that's unlikely to change, I'm afraid. (Would you be interested in creating a fork as described in that issue?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants