Email users #119
Merged
Email users #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dethos: Most functionality seems ok, but deleting an already sent notification gives me this:
|
|
@jlbribeiro: To delete the success message we would have to override this huge function, that is why I opted to leave it there (since it is only visible to admins): |
|
@dethos
It seems good to go. Do you want to fix this first or may I merge it? |
|
Not worth holding the PR. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the administrator of one Hawkpost instance wants to communicate to its users an issue or important information, such as downtime for maintenance, it now can use this simple built in feature.