Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reply_to is filled if the user is authenticated #290

Merged
merged 2 commits into from Apr 4, 2019
Merged

Conversation

dethos
Copy link
Collaborator

@dethos dethos commented Oct 30, 2018

Addresses #218

This is a simple implementation of a requested feature. If a user is logged in when submitting a box, the reply_to field will be filled with his email address.

We could added a field for users not logged in, however we would have to validate the users is not trying to impersonate (not providing is own email address).

A possible improvement for this PR, would be to allow the logged in user to opt out of this feature.
Would that be preferable?

@dethos
Copy link
Collaborator Author

dethos commented Dec 17, 2018

any news about this?

Copy link
Member

@pjaneiro pjaneiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dethos just to clarify. If I'm filling a box, and am logged in, my e-mail will be used in the reply_to field? Is that the expected behaviour?

@dethos
Copy link
Collaborator Author

dethos commented Dec 21, 2018

Yes, so the receiver can know who sent it (or to whom he should reply).
Thinking a little more about this:

A possible improvement for this PR, would be to allow the logged in user to opt out of this feature.
Would that be preferable?

I think Hawkpost should give the user the possibility to add this information. So instead of being opt-out we should aim for it to be opt-in 🤔

@pjaneiro
Copy link
Member

Yes, considering the specific task, I think opt-in would be preferable here. Should that be addressed in this PR, or should a new PR be created just with that purpose?

@dethos
Copy link
Collaborator Author

dethos commented Mar 10, 2019

@pjaneiro just made it opt-in. Authenticated users now can check a checkbox in case they want their email added to ReplyTo.

@dethos
Copy link
Collaborator Author

dethos commented Apr 2, 2019

@pjaneiro any news?

Copy link
Member

@pjaneiro pjaneiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge away 👍

@dethos dethos merged commit 2e3c29d into master Apr 4, 2019
@dethos dethos deleted the add-reply-to branch April 4, 2019 16:33
@dethos dethos mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants