Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for expired and revoked keys #42

Merged
merged 1 commit into from May 9, 2016
Merged

Check for expired and revoked keys #42

merged 1 commit into from May 9, 2016

Conversation

dethos
Copy link
Collaborator

@dethos dethos commented May 6, 2016

This PR handles the following issues:

  • Fixes a bug that lets the users submit a key, without fingerprint check
  • Add revoke and expiration checks to settings form
  • Adds a daily task to update and check the users keys (Issue: Update keyserver keys #1)

@nunosilva800
Copy link
Collaborator

I'm not very good with Python but LGTM.
I think at least the fingerprint check should be covered by tests.

@dethos
Copy link
Collaborator Author

dethos commented May 6, 2016

@Onumis Agree, the whole project needs to have a good coverage of tests. Probably we should give some priority to this #15 issue, before advancing to the next features.

@dpflucas
Copy link
Member

dpflucas commented May 9, 2016

Seems OK to me. Will merge this, agreeing that from now on we should focus on having features shipped with tests.

@dpflucas dpflucas merged commit cc1babc into master May 9, 2016
@dethos dethos deleted the update_keys_task branch May 13, 2016 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants