Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MeshComponent parameter types should extend Component parameter types #378

Closed
2 of 19 tasks
hirako2000 opened this issue Apr 27, 2018 · 0 comments
Closed
2 of 19 tasks

MeshComponent parameter types should extend Component parameter types #378

hirako2000 opened this issue Apr 27, 2018 · 0 comments
Assignees
@hirako2000
Labels
TYPES
Projects
v2.2

Comments

@hirako2000
Copy link
Collaborator

hirako2000 commented Apr 27, 2018 •
edited

Two things are missing there:

  • Component parameter type is object, it should be taking an object containing, optionally, an array of modules, and a module manager.
  • MeshCompnent params should extend Component params
Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
@hirako2000 hirako2000 self-assigned this Apr 27, 2018
hirako2000 added a commit that referenced this issue Apr 27, 2018
@hirako2000
Defines types for Component params, MeshComponent params now extends …
ab3c936 
…Component params - #378
hirako2000 added a commit that referenced this issue Apr 27, 2018
@hirako2000
Export Interfaces - #378
93eb1c8
hirako2000 added a commit that referenced this issue May 13, 2018
@hirako2000
Merge pull request #379 from WhitestormJS/#378
9e4bafa 
PR for #378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirako2000 hirako2000

Labels
TYPES
Projects
No open projects
v2.2
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hirako2000