Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistency across :ok/:missing/:loaded #2

Closed
whitfin opened this issue Apr 7, 2016 · 1 comment
Closed

Ensure consistency across :ok/:missing/:loaded #2

whitfin opened this issue Apr 7, 2016 · 1 comment
Assignees
@whitfin
Labels
enhancement

Comments

@whitfin
Copy link
Owner

whitfin commented Apr 7, 2016

The main CRUD functions deal with the following:

  • :ok if the key was found
  • :missing if the key was not found
  • :loaded if the key was found via fallback

We should expand this to everywhere it's applicable - the use case which triggered this issue is take/3 always returning :ok but I'm pretty sure it applies to others too.
@whitfin whitfin changed the title Ensure consistency across :ok/:missing/:loaded Ensure consistency across :ok/:missing/:loaded Apr 7, 2016
@whitfin whitfin self-assigned this Apr 7, 2016
@whitfin
Copy link
Owner Author

whitfin commented Apr 10, 2016

A lot of this is being handled by #5 in the reworking of the stats gathering (because I'm fixing the above as I go). I'll leave this issue open for now and update when #5 has come to a conclusion.

@whitfin whitfin mentioned this issue Apr 11, 2016
Merged
@whitfin whitfin closed this as completed Apr 11, 2016
@whitfin whitfin mentioned this issue Dec 23, 2016
Closed
@whitfin whitfin mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whitfin whitfin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whitfin