Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading provisions to support Warmers as well as Hooks #332

Closed
whitfin opened this issue Mar 21, 2024 · 1 comment · Fixed by #340
Closed

Consider upgrading provisions to support Warmers as well as Hooks #332

whitfin opened this issue Mar 21, 2024 · 1 comment · Fixed by #340
Assignees
Milestone

Comments

@whitfin
Copy link
Owner

whitfin commented Mar 21, 2024

Right now provisions are only available on hooks, which is odd because warmers feel like they should also support them.

We should look into adding support on warmers to ensure the cache is always in sync.

@whitfin whitfin added this to the v3.7.0 milestone Mar 21, 2024
@whitfin whitfin self-assigned this Mar 21, 2024
@whitfin whitfin modified the milestones: v3.7.0, v4.0.0 Mar 22, 2024
@whitfin
Copy link
Owner Author

whitfin commented Mar 23, 2024

After looking at this further I believe the provisioning should be pulled out of hooks into a generic behaviour and module to handle provisioning for anything relevant in a cache (which will be hooks + warmers on first implementation).

This is technically not a breaking change, and I doubt many people are actually using this functionality that much anyway, but it's big enough that I'd rather do it in the next major.

I thought about stripping out provisions completely, because there's literally only one, but the implementation is so straightforward that it's not hurting anything even if the abstraction isn't entirely useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant