Toggling diagnostics resets my customization

[oredaze]

When I <Plug>(toggle-lsp-diag) they turn off fine, but when I do that again the diagnostics lose any of the settings I have assigned. If I do <Plug>(toggle-lsp-diag-default) my customization is back again. This is unexpected behavior. I would like to toggle on/off without it changing any settings. Pressing two keys to turn them back on [properly] is also unacceptable.

[xfzv]

Can confirm the behavior described, same here. I setup toggle-lsp-diagnostics.nvim as follows with lazy.nvim:

{
    "WhoIsSethDaniel/toggle-lsp-diagnostics.nvim",
    event = { "BufReadPost", "BufNewFile" },
    config = function()
      require("toggle_lsp_diagnostics").init(vim.diagnostic.config())
    end,
},

[WhoIsSethDaniel]

If I understand your problem correctly this behavior is documented in the README:

You can toggle ALL settings, at once, to either on or off by using the appropriate mapping or command. The toggle-lsp-diag >
mapping toggles ALL settings either on or off. It does NOT toggle back to a previous state. So, if you toggle off underline, then
turn ALL settings off, and then turn ALL settings back on again, the underline will re-appear. To get the settings back to the
default you can use the toggle-lsp-diag-default mapping or the :ToggleDiagDefault command.

You shouldn't need to hit two different keys to go back to your settings. Just use :ToggleDiagOff for turning them off and :ToggleDiagDefault for toggling them back on. There is no need to use :ToggleDiagOn ever in your case.

The names are odd, but that's for historical reasons.

[WhoIsSethDaniel]

btw, sorry for such a long time to answer your bug report. Real-life got in the way.

[WhoIsSethDaniel]

I just realized what you were trying to say in your earlier comment. I'll see what I can do about the toggling.

[WhoIsSethDaniel]

I believe this issue is fixed.

[xfzv]

All good here now, thank you @WhoIsSethDaniel