Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Tale state changes during in-progress jobs #137

Closed
craig-willis opened this issue Feb 5, 2021 · 1 comment · Fixed by #190
Closed

Handle Tale state changes during in-progress jobs #137

craig-willis opened this issue Feb 5, 2021 · 1 comment · Fixed by #190
Labels
bug Something isn't working

Comments

@craig-willis
Copy link
Contributor

craig-willis commented Feb 5, 2021

Steps to Reproduce

  1. Import a tale from Zenodo (e.g., Click "Run this on Whole Tale" for https://sandbox.zenodo.org/record/718277)
  2. Note that a Tale is created and you are redirected to the metadata page, but metadata is missing involatile data datasets used/related identifiers
  3. A job notification appears for the import process (import notifications require Add notifications for shared events girder_wholetale#445)
  4. Inspect Tale status during import process (via Swagger or otherwise) and value should be PREPARING (0) until the job completes (READY).
  5. When import is complete, the tale metadata page is unchanged
  6. Refresh, note that Involatile Data section is updated

Expected Results

  • The UI indicates that the Tale is in a pending state
  • When the Tale state changes to READY (1) the metadata page is refreshed/updated

Actual Results

  • Tale state changes are not reflected in UI and incomplete metadata is displayed
@craig-willis
Copy link
Contributor Author

Per 3/15 dev call, we've determined the following:

  1. The primary problem of the tale metadata not updating during import is resolved by First-pass at a pattern for handling state updates from SSE #139
  2. The secondary issue that the tale status is not presented to the user is still open. This could be resolved by adding the tale status to the metadata page to display Not Ready, Ready or Error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant