Display of mz:is_ceased always shows as 1 instead of reflecting actual data value

[nvkelso]

While viewing Faymont neighbourhood in France. I observed that the mz:is_ceased is always set to 1, even though nonsensically the mz:is_current property is still 1, and there is no edtf:* details indicating the place is actually ceased. Browsing around it seems like this property is displaying on many records, including the country of France.

Reviewing the src GeoJSON data and it seems like this property isn't present in the data for Faymont.

Why is this property being added? Should it be added? The counts are useful at the top of the new page, but I'm not sure about mixing in calculated properties and data properties in the main body of the page... or we need an indicator (like a background color?) to alert in these situations?

Is mz:is_is_ceased being imputed during page render? If so there's a bug in how it's being calculated.

[thisisaaronland]

This is technically a bug in that the code here should also be checking for edtf.UNKNOWN_2012. On the other hand we should also update all those pre-2019 EDTF strings in all the WOF records.

https://github.com/whosonfirst/go-whosonfirst-spelunker/blob/main/document/existential.go#L31-L35
https://github.com/sfomuseum/go-edtf/blob/main/edtf.go#L16C7-L16C19

Either way, this will require re-indexing things (which will at least be a good "wax on, wax off" exercise). Leaving this issue open until this is completed:

whosonfirst/go-whosonfirst-spelunker#2

[thisisaaronland]

One short-term solution would be to trap and remove mz:is_* properties here (until the re-indexing is complete):

https://github.com/whosonfirst/go-whosonfirst-spelunker-httpd/blob/main/static/javascript/whosonfirst.spelunker.properties.js

[straup]

• https://github.com/whosonfirst/go-whosonfirst-opensearch/releases/tag/v0.0.15
• https://github.com/whosonfirst/go-whosonfirst-spelunker/releases/tag/v0.0.1

[nvkelso]

Nice! I think I'm awaiting a deploy to verify fix... No hurry.

[thisisaaronland]

The issue has not been fixed. These are just steps along the way. The real fix is going to be updating all the WOF records with bunk EDTF values:

• https://github.com/whosonfirst/go-whosonfirst-edtf?tab=readme-ov-file#update-open-unknown

[nvkelso]

@stepps00 FYI this implicates whosonfirst-data/whosonfirst-data#1914 and crawling all the repos and updating EDTF values.

[straup]

Fixed with re-indexing (and changes to whosonfirst/go-whosonfirst-spelunker).

[nvkelso]

Verified, thanks!