Add error code to Mypy message #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick91
force-pushed
the
feature/error-codes
branch
3 times, most recently
from
42fc700
to
b5ffed6
Compare
patrick91
force-pushed
the
feature/error-codes
branch
from
41172c3
to
a8ff757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for error codes in Mypy.
So instead of just adding
# type: ignorewe now add# type: ignore[misc]:)I also changed the regex to use named groups so it is easier to read (and thanks to @BryceBeagle for helping me with it) :D
Ideally we should add support for error codes when removing type ignore comments, but I can do that in another PR :)