Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ bounding boxes and full local dataset #134

Merged
merged 26 commits into from
Feb 3, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Jan 25, 2021

No description provided.

@lalmei lalmei changed the title [WIP] bounding boxes and full local dataset bounding boxes and full local dataset Jan 26, 2021
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add dep to setup.cfg (I can't seem to be able to make suggestions for unchanged sections of the code)

requirements.txt Outdated Show resolved Hide resolved
src/whylogs/app/logger.py Outdated Show resolved Hide resolved
@lalmei lalmei requested a review from andyndang January 29, 2021 18:50
@lalmei lalmei force-pushed the WHY-1849_annotation_local_dset branch from 388f92d to e113c14 Compare January 31, 2021 18:13
src/whylogs/app/logger.py Show resolved Hide resolved
src/whylogs/app/logger.py Outdated Show resolved Hide resolved
Co-authored-by: Andy Dang <26821974+andyndang@users.noreply.github.com>
requirements-test.txt Outdated Show resolved Hide resolved
@lalmei lalmei requested a review from andyndang February 2, 2021 17:00
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei lalmei added the feature label Feb 2, 2021
@lalmei lalmei changed the title bounding boxes and full local dataset ✨ bounding boxes and full local dataset Feb 2, 2021
@lalmei
Copy link
Contributor Author

lalmei commented Feb 2, 2021

I will merge this after the drafter to test it out

@lalmei lalmei merged commit d4dedd4 into mainline Feb 3, 2021
@lalmei lalmei deleted the WHY-1849_annotation_local_dset branch February 17, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants