Update BentoML example #1479
Merged
Update BentoML example #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naddeoa
force-pushed
the
bentoml
branch
5 times, most recently
from
a74bf54
to
25a7215
Compare
jamie256
previously approved these changes
Mar 8, 2024
This updates the example for BentoML to no longer use atexit or the original rolling logger, and it uses the more common (in BentoML examples) function based service interface. It also highlights logging to multiple dataset ids within a single service. The atexit only really works for toy local examples. BentoML prefers that you use its lifecycle management hooks to do startup and shutdown related logic. The old logger couldn't gracefully handle multiple dataset ids either, it required changing the default dataset id between logging calls.
|
@jamie256 updated to fix comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the example for BentoML to no longer use atexit or the original rolling logger, and it uses the more common (in BentoML examples) function based service interface. It also highlights logging to multiple dataset ids within a single service.
The atexit only really works for toy local examples. BentoML prefers that you use its lifecycle management hooks to do startup and shutdown related logic. The old logger couldn't gracefully handle multiple dataset ids either, it required changing the default dataset id between logging calls.