Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review fixImports #42

Open
schomatis opened this issue Aug 7, 2018 · 1 comment
Open

Review fixImports #42

schomatis opened this issue Aug 7, 2018 · 1 comment
Assignees
@schomatis

Comments

@schomatis
Copy link
Collaborator

schomatis commented Aug 7, 2018 •
edited

Why is it necessary? Why is it not incorporated in the normal flow of the gx-go rewrite command and needs to be called separately with the --fix flag?

In the go-unixfs repo it is necessary to call this function (through --fix) because rewrite --undo (and hence gx-go link -r) is not working.
@schomatis schomatis self-assigned this Aug 7, 2018
@whyrusleeping
Copy link
Owner

@schomatis i have it as a separate option because you ideally shouldnt have to use it, plus it is hypothetically slower than the normal gx-go rw/uw commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schomatis schomatis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whyrusleeping @schomatis