Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace() clears CSS rules before throwing NetworkError #108

Closed
nordzilla opened this issue Dec 31, 2019 · 1 comment
Closed

replace() clears CSS rules before throwing NetworkError #108

nordzilla opened this issue Dec 31, 2019 · 1 comment

Comments

@nordzilla
Copy link
Contributor

This is similar to #101. The spec currently instructs that the sheet should clear its rules on step 3, but we could still throw a NetWorkException in step 4.

I am proposing that we remove the step 3 all together, because the rules will be reassigned if step 4 is successful.
@nordzilla nordzilla mentioned this issue Dec 31, 2019
Closed
@nordzilla
Copy link
Contributor Author

I misread the spec. I read that it was throwing a NetworkException. Instead, it is rejecting the promise with a NetworkException. This is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nordzilla