Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use with data-attribute #126

Open
babielmam opened this issue Jul 8, 2019 · 3 comments
Open

Option to use with data-attribute #126

babielmam opened this issue Jul 8, 2019 · 3 comments

Comments

@babielmam
Copy link

We are using inert in a recent project. It works well and we want to continue to use it.
Our product must deliver valid HTML without errors. It is checked with the W3 validator.

However, the validator doesn't allow to use the inert attribute anywhere, because it isn't part of the spec. As to why was explained in this issue of the HTML spec.

Would it be possible to have the polyfill not only work with [inert]-attribute, but also with a [data-inert]-attribute? That way we can make use of this future-proof feature (and might do a little switch somewhere in the future), but also deliver fully valid HTML.

@robdodson
Copy link
Collaborator

I'm supportive of this. @alice what do you think?

@alice
Copy link
Member

alice commented Jul 16, 2019

Sorry for being so slow! Yes, that looks very reasonable to me.

@babielmam
Copy link
Author

babielmam commented Sep 4, 2019

@robdodson, @alice Could you have a look at the associated PR #128 please?

babielmam added a commit to babielmam/inert that referenced this issue Sep 4, 2019
babielmam added a commit to babielmam/inert that referenced this issue Oct 4, 2019
babielmam added a commit to babielmam/inert that referenced this issue Oct 4, 2019
babielmam added a commit to babielmam/inert that referenced this issue Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants