Skip to content
This repository has been archived by the owner on Jun 26, 2019. It is now read-only.

Accounting with encodedBodySize doesn't work with SDCH #3

Closed
csharrison opened this issue Aug 2, 2016 · 4 comments
Closed

Accounting with encodedBodySize doesn't work with SDCH #3

csharrison opened this issue Aug 2, 2016 · 4 comments

Comments

@csharrison
Copy link
Collaborator

A malicious iframe can request tiny resources that advertise huge dictionaries. Unless we data account those dictionaries, the frame can use the huge dictionaries as an effective way to bypass data accounting.

Counting SDCH downloads to a particular frame has a complex implementation cost in Chromium. Do we think we can move encodedBodySize to decodedBodySize to fix this bug?

@igrigorik
Copy link
Member

Didn't we deprecate SDCH? Is this still relevant?

@jkarlin
Copy link
Collaborator

jkarlin commented Jun 28, 2017

Chrome has deprecated it. Not sure about others. Brotli may run into a similar issue in the future.

@igrigorik
Copy link
Member

AFAIK, so has everyone else: https://www.chromestatus.com/feature/5763176272494592.

I agree that there will be edge cases to consider here with any form of shared dictionary / delta compression mechanisms. However, none of those are well formed yet.. I propose we close this and tackle that when it actually starts to smell like a real thing? :)

@jkarlin
Copy link
Collaborator

jkarlin commented Jun 29, 2017

sgtm

@jkarlin jkarlin closed this as completed Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants