New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWT tokens inside Cookies #27
Conversation
Thanks for the comments. I'll assess this again as soon as I can find some time. |
@wichert I found some time to dedicate to this, but it seems your current master branch is failing tests. |
It is added on the testing extra_requires
@wichert I have rebased this branch to the current master and augmented tests. Coverage looks good to me at this time. Please review my last comments and let me know if you need any changes. Please note that there's always the option that we bake the whole cookie support within the original |
This looks very good! Can you please also add an example to the README? |
Hi, what is the progress? I am starting with a new site using pyramid and would love to use tokens inside Cookies. |
Hi! |
Great! Pleas provide also some examples, I installed it manually and now trying to figure out how it is working. |
@wichert @dragonnn Updated the PR with some fixes and documentation. Could you please review it again? Again: Please note that there's always the option that we bake the whole cookie support within the original JWTAuthenticationPolicy class instead of coding a new policy as I've done. Let me know if you find that a better solution. |
@phrfpeixoto This looks great! I’ve merged the pull request and will look at making a release soon. |
Nice! |
I can confirm it works fine :), can you bump the version/create a release so pip catches it? |
These changes adds support for using JWT token on HttpOnly cookies.
Key benefits are: