Bug 1134730. DOM proxy finalizers should not assume that the JS objec…

…t has an actual reference to the DOM object (and in particular that the slot it's stored in is a private slot).
rmottola · Jan 7, 2019 · bd4f51b · bd4f51b
1 parent ce850b5
commit bd4f51b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/dom/bindings/Codegen.py b/dom/bindings/Codegen.py
@@ -10626,7 +10626,8 @@ def __init__(self, descriptor):
         self.descriptor = descriptor
 
     def getBody(self):
-        return ("%s* self = UnwrapProxy(proxy);\n\n" % self.descriptor.nativeType +
+        return (("%s* self = UnwrapPossiblyNotInitializedDOMObject<%s>(proxy);\n" %
+                 (self.descriptor.nativeType, self.descriptor.nativeType)) +
                 finalizeHook(self.descriptor, FINALIZE_HOOK_NAME, self.args[0].name).define())