Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken on Swift 4.1 #13

Closed
jseibert opened this issue Mar 6, 2018 · 4 comments
Closed

Broken on Swift 4.1 #13

jseibert opened this issue Mar 6, 2018 · 4 comments

Comments

@jseibert
Copy link
Contributor

jseibert commented Mar 6, 2018

Swift 4.1 apparently includes ABI changes that cause this library to fail completely. ~All tests crash with EXC_BAD_ACCESS.

Instructions for grabbing the latest Swift 4.1 snapshot here:

https://gist.github.com/tanner0101/cdb77c7f58d53af2ba2da5d39415389a
@wickwirew
Copy link
Owner

Thanks for the issue, been meaning to update it for swift 4.1. I've create a swift-4.1 branch. So hopefully soon it will have support!

@wickwirew
Copy link
Owner

wickwirew commented Mar 7, 2018 •
edited

I have updated the swift-4.1 branch, and now all tests pass. Let me know if you have any more issues. Going to merge swift-4.1 to master once Xcode 9.3 is out of beta.

@jseibert
Copy link
Contributor Author

jseibert commented Mar 7, 2018

Wow you're fast, awesome! Works perfectly for me.

@wickwirew
Copy link
Owner

Glad to hear it! Thanks for trying it out again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jseibert @wickwirew