-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 5.0 metadata build errors #37
Comments
|
Awesome thanks! I have a swift 5 branch locally. Hopefully will finish it up soon. Sorry for the wait. |
@wickwirew Can you push the branch so I can help, if I can? I was able to make it work except for generics. @jckarter helped me with some directions: But I couldn't get it to work properly. How far were you able to get? Oh, and looks like |
@wickwirew Also, please check apple/swift#15565 (comment). See if you have any ideas. |
@paulofaria I’ll push soon. The latest OS update bricked my laptop so it may take a little time |
@wickwirew any update? Would love to pitch in and help out if anything is left to do as well! |
@robertjpayne made some good progress tonight! Got it reading from the Still have to workout getting the generic argument descriptor so we can pass the types to |
Thought I would note that I'm seeing this error as well in Swift 4.2. I setup a Vapor test project using Swift package manager with GraphQL as a dependency . It looks like GraphQL has a dependency on Runtime and trying to build a generated Xcode project fails in the Runtime framework with the same error noted by the OP. If it helps my Package.swift looks like this:
|
@paulofaria @robertjpayne pushed the I was able to correctly get the generic argument vector, and pass that into |
Just pushed a temp fix for class support. All tests pass. The class generic argument vector's offset is hard coded and not calculated like it should be. Still needs some clean up as well but should be hopefully enough to not block people from upgrading to swift 5 |
Swift 5 support has been merged and |
Getting some build errors in Swift 5, in
Metadata.swift
andTypeInfo.swift
:(Those errors pop up for every
case
.)That init is defined here: https://github.com/wickwirew/Runtime/blob/master/Sources/Runtime/Metadata/MetadataType.swift#L61
so I'm not sure why Swift 5 is refusing to see it…
Note this happens when building the project from scratch, or when building as an SPM dependency.
Troubleshooting notes:
typeInfoConvertible = StructMetadata.init(type: type)
.StructMetadata.swift
fails with aerror: reference to invalid associated type 'Layout' of type 'StructMetadata'
, on the init declaration itself.typealias Layout = FooMetadata
declarations fixes those errors, and allowed me to remove the manualFoo.init(type: type)
…swift build
from the terminal completes just fine; is this only a problem in Xcode? Is there a problem with my deployment target? I've rebuilt the.xcodeproj
withswift package generate-xcodeproj
…Anywho, here's the branch if you wanna take a look: https://github.com/noahemmet/Runtime/tree/swift5
The text was updated successfully, but these errors were encountered: