Framework/Test Targets for macOS #4
Conversation
... sources in Sources, tests in Tests, Package.swift, update README.md
... for SPM, do not use the CG* DefaultConstructors.
... more complete SPM instructions.
... to install section.
... all those static arrays, if only we had a Runtime ;-)
... tied it to Swift 4, doesn't work for 3, right?
- Linux has no `class_createInstance`, which is used for creating instances. This would need to be done differently here. - Some issue w/ `NSObject` which is probably also due to the missing ObjC runtime
Add support for Swift Package Manager
... same files, different target for Cocoa.
... which crash, btw ;-)
|
What test fails? Is it the create class in the issue you made? |
|
Check issue #5. This is not related to Linux, it is just the same tests you run on iOS, fail on macOS. Seems to be an RC issue. This PR is just adding a target to the Xcode project to build a macOS framework & tests. It should be fine to merge, unless they break the pods, don't know how that works. |
|
I think I may be reverting the SPM stuff so I'm going to hold off. Not a big fan of the massive restructure. When I first looked over the PR it didn't show all the the moved files and only showed about 400 line changes but once merged I saw the full extent of the changes. My mind was also clouded by excitement of my first contributor lol. I think all of the changes minus the file restructure are good and we need them in but I would like to keep the project structure the same. In swift 4 they did a full redesign of the SPM and I believe now you don't have to have all of the |
|
Hey, no problem, it's your very own project! ;-) I'm not entirely sure where you see a "massive restructure", the files just got moved into Sources/Tests, thats it, but sure, if you don't like it, there is no obligation to accept PRs :-) |
|
I made a new |
|
BTW: This PR #4 is completely unrelated to SPM or Linux. It is about adding a regular macOS Target to the regular Xcode project you have. Do you want this? I think it would be good to get it working on macOS first, and then checkout Linux. I think it would be good to have at least a (also: I'm personally fine w/ not having instance construction, I'm mostly interested in property write access, which does seem to work fine across platforms). |
|
Anyways, if you reverted the directory structure, this would need an update, so do not commit merge yet ;-) |
|
Actually, let me close this, I'm going to create a new PR. |
I hope those do not confuse the Cocoapod.
This stuff makes it build as a Cocoa framework. Building things works fine, but the tests actually crash on macOS (same w/
spm testbtw).