Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to disable add-on related e-mail notifications #359

Closed
Noordfrees opened this issue Aug 19, 2021 · 2 comments
Closed

Add settings to disable add-on related e-mail notifications #359

Noordfrees opened this issue Aug 19, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Noordfrees
Copy link
Member

The add-ons server sends e-mail notifications to add-on authors to inform them about new Transifex string issues in their add-ons. As of my next branch it also sends a mail when a maintainer deletes your add-on.
Like all e-mail notifications this should be configurable under https://www.widelands.org/notification/. The server already reads in the notification_noticetype and notification_noticesetting tables to discover whether this setting exists and if so whether a user has disabled notices. (Default is to assume they're enabled.) The notice type labels are assumed to be called addon_transifex_issues and addon_deleted respectively. What's left to do is to add the settings to the website

@Noordfrees Noordfrees added the enhancement New feature or request label Aug 19, 2021
@frankystone
Copy link
Contributor

This is a difficult task. The notification app is tied to emailing from the website-server. It is not possible without much effort to use this app for email-settings regarding the add-ons server (for mails send by the add-ons server).

To archive this the model(s) and codebase of the notification app needs to be heavily adapted.

Maybe a better approach is to create a new app wladdons_settings or so. As far i understand you just want to know if users want emails from the addons-server, or not. So just a boolean...

@frankystone frankystone self-assigned this Dec 9, 2021
@frankystone frankystone linked a pull request Dec 10, 2021 that will close this issue
@frankystone frankystone removed a link to a pull request Dec 11, 2021
@frankystone
Copy link
Contributor

Fixed by #374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants