Codecheck: 'const' for a literal parameter ... does not catch all instances

[bunnybot]

In this function:

void foo(const int bar,
                const int baz,
                const RGBColor& blah)

I will get the following codecheck error:

'const' for a literal parameter is an implementation detail. Remove the const from the interface definition.

However, with this function:

void foo(const int bar, const int baz, const RGBColor& blah)

no error is triggered.

---

Imported from Launchpad using lp2gh.

• date created: 2016-03-08T09:37:15Z
• owner: gunchleoc
• the launchpad url was https://bugs.launchpad.net/bugs/1554438

[Noordfrees]

I get this one all the time. This false positive is sooo annoying…

E.g.: 8c502ef @ https://travis-ci.org/github/widelands/widelands/jobs/734548358#L3627

[gunchleoc]

It's not a false positive - the rule is performing there as it's intended to do.

I don't know what motivated this rule though. @SirVer do you remember?

[Noordfrees]

It is a false positive when it catches the definition as well as the declaration. There is no reason why I shouldn't be allowed to make a literal parameter const in a .cc file, the rule should apply only to headers. Perhaps it should scan only .h files?

[Niektory]

It seems the main problem is that it checks line by line, so it cannot distinguish declarations from definitions when they span multiple lines. Perhaps it shouldn't match any lines that don't end with a ;.

[gunchleoc]

+1 for restricting it to .h files. Sorry, I overlooked that it was in a .cc file.

Perhaps it shouldn't match any lines that don't end with a ;.

Difficult for long function signatures that span multiple lines. We'd need to rewrite the rule to support multiline.