Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move chat history from EditBox to GameChatPanel #1668

Closed
bunnybot opened this issue Sep 9, 2019 · 0 comments · Fixed by #5944
Closed

Move chat history from EditBox to GameChatPanel #1668

bunnybot opened this issue Sep 9, 2019 · 0 comments · Fixed by #5944
Labels
cleanup & refactoring Improving our code quality good first issue Good for newcomers

Comments

@bunnybot
Copy link

bunnybot commented Sep 9, 2019 •
edited

At the moment, the chat history is implemented in EditBox. It logical place is the GameChatPanel though. We can use boost:signals2 to notify the GameChatPanel of relevant key presses.

Imported from Launchpad using lp2gh.
@bunnybot bunnybot added cleanup & refactoring Improving our code quality Low labels Sep 9, 2019
@TinoM TinoM added good first issue Good for newcomers and removed lowhangingfruit labels Sep 11, 2019
@gunchleoc gunchleoc added this to Needs triage in Issue triage Sep 13, 2019
@gunchleoc gunchleoc removed this from To Do in Issue triage Oct 1, 2019
@tothxa tothxa mentioned this issue Jun 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup & refactoring Improving our code quality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Debugconsole and input history improvements tothxa/widelands
3 participants
@TinoM @gunchleoc @bunnybot