Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net relay should measure ping to players and Widelands should show it in the UI #3236

Open
bunnybot opened this issue Sep 9, 2019 · 5 comments
Assignees
Labels
multiplayer & networking Internet & LAN gaming features, networking backend

Comments

@bunnybot
Copy link

bunnybot commented Sep 9, 2019

Pulled out from https://code.launchpad.net/~widelands-dev/widelands/net-relay/+merge/332386

Since the net relay can measure ping to all players, it can identify "black sheeps" that lack the game. The host (or even better all players) of the game should be able to see this information somewhere in-game and the host can decide to kick a player/observer because of this.

The natural place for this would be in the chat window - e.g. we could add a list of participants in the chat window in game and add ping times as green/yellow/red indicators next to it.


Imported from Launchpad using lp2gh.

@bunnybot
Copy link
Author

bunnybot commented Sep 9, 2019

(by gunchleoc)
A list of participants would be awesome in any case. Especially if the username gets pasted into the editbox if you click on one - that will make whispering easier too.

@gunchleoc gunchleoc added multiplayer & networking Internet & LAN gaming features, networking backend and removed network labels Sep 12, 2019
@gunchleoc gunchleoc added this to Needs triage in Issue triage Sep 13, 2019
@gunchleoc gunchleoc removed this from To Do in Issue triage Sep 28, 2019
@Notabilis Notabilis self-assigned this Aug 23, 2020
@klaus-halfmann
Copy link
Contributor

klaus-halfmann commented Feb 14, 2021

I get these warnings:

3236-player-list/src/wui/CMakeLists.txt:1: 
wui_player_list misses DEPENDS on logic_constants, because it includes logic/widelands.h
wui_player_list misses DEPENDS on network, because it includes network/participantlist.h
wui_player_list misses DEPENDS on graphic_image_cache, because it includes graphic/image_cache.h
wui_player_list misses DEPENDS on graphic_playercolor, because it includes graphic/playercolor.h
wui_player_list DEPENDS on graphic_styles, but includes none of its headers.

@klaus-halfmann
Copy link
Contributor

src/logic/mutable_addon.h:101:3: warning: extra ';' after member function definition

@matthiakl
Copy link
Member

src/logic/mutable_addon.h:101:3: warning: extra ';' after member function definition

Unrelated. I will fix it in my current PR (#4678)

@Notabilis
Copy link
Contributor

Unrelated. I will fix it in my current PR (#4678)

Indeed. I fixed it anyway, but should merge fine with your PR I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiplayer & networking Internet & LAN gaming features, networking backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants