Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make savegame loading less succeptible for changes in lua #3671

Closed
hessenfarmer opened this issue Feb 5, 2020 · 0 comments · Fixed by #3961
Closed

make savegame loading less succeptible for changes in lua #3671

hessenfarmer opened this issue Feb 5, 2020 · 0 comments · Fixed by #3961
Labels
bug Something isn't working saveloading & compatibility Map/Game saving or loading, compatibility with older versions urgent Needs to be fixed before the next release.
Milestone
build21-rc1

Comments

@hessenfarmer
Copy link
Contributor

Currently savegame loading easily breaks if lua working programs are changed.

This should be fixed in a way that if a program in the savegame is not found in the productionsite definition anymore just reinitialize the program working state of the productionsite.

Perhaps some other parts of saveloading could be hardened this way
@hessenfarmer hessenfarmer added the enhancement New feature or request label Feb 5, 2020
@hessenfarmer hessenfarmer mentioned this issue Feb 5, 2020
Merged
@gunchleoc gunchleoc added the saveloading & compatibility Map/Game saving or loading, compatibility with older versions label Feb 6, 2020
@hessenfarmer hessenfarmer mentioned this issue Mar 6, 2020
Closed
@Noordfrees Noordfrees added bug Something isn't working and removed enhancement New feature or request labels Jul 2, 2020
@Noordfrees Noordfrees self-assigned this Jul 2, 2020
@Noordfrees Noordfrees mentioned this issue Jul 2, 2020
Closed
@Noordfrees Noordfrees added this to the build21-rc1 milestone Jul 2, 2020
@Noordfrees Noordfrees added the urgent Needs to be fixed before the next release. label Jul 2, 2020
@gunchleoc gunchleoc linked a pull request Jul 3, 2020 that will close this issue
Replace unknown programs with "work" while saveloading #3961
Merged
@Noordfrees Noordfrees removed their assignment Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working saveloading & compatibility Map/Game saving or loading, compatibility with older versions urgent Needs to be fixed before the next release.
Projects
None yet
Milestone
build21-rc1
3 participants
@gunchleoc @hessenfarmer @Noordfrees