AI prefers heroes although the enemy can't be attacked

[frankystone]

Just found this when watching an ai only game: In this map are several places where one can see the enemy but can't attack him because a broad river prevents attacking. When the AI players reached those places they always set their military sites to
store heroes. This weakens the AI.

To reproduce

1. Load this network game wl_autosave_nethost_00.zip
2. Follow the rivers to see what happens

Expected behavior
AI should calculate if the military sites are in danger or not and set the soldiers accordingly.

Screenshots
Screenshots are probably from another game.

Version:

• OS: archlinux
• Widelands Version: 1.2~git26123 (e416a98@master) Debug

Additional context
Maybe the same code as for calculating if a player can attack can be reused.

[hessenfarmer]

I can confirm this but I can't promise any fix soon. Problem is that the AI lacks a lot of concepts a human player has. one of these missing concepts is awareness of the spatial situation on the map.