-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only trigger tests in workflow if something relevant has changed #6020
Comments
By the way, widelands/.github/workflows/build.yaml Line 22 in 2d5e5dc
I found more files:
Should some of those be checked as well? |
Could one of the test suites also create an artifact? I can only download for MacOS and Windows, but not linux: https://github.com/widelands/widelands/actions/runs/5556166018#artifacts (For pull requests, on master there is an appimage for linux) |
To just skip steps or jobs if some files have changed, this action could help: https://github.com/dorny/paths-filter |
Do you have a special reason why you need the Linux artifacts? Most developers use Linux for developing and simply compile it locally. Also because of different distributions the dynamically linked binaries from Ubuntu may not work for you. Please consider moving this issue into our discussion thread on this topic: #5880 |
Right, it would likely not work for me because of those libraries. I would like to see how pr #6017 looks (and test if pr #6001 works on netclient). I use linux but would prefer to not install a build environment for every project I contribute to. Since I wrote this I made some tries anyway but did not yet succeed. 😞 |
Please fill out the relevant sections below and delete the rest.
Describe the bug
Tests are also run if only a file changed which has nothing to do with the code
example: #6019
Expected behavior
I suggest to skip tests on obvious cases by using ...
either
paths
orpaths-ignore
for the entire workflow (workflow-syntax-... on docs.github)or conditions for some jobs (using-conditions-... on docs.github)
some (include) paths for ...
compile and tests: src/, data/ (should we exclude some content?), test/, cmake/ (?), regression_test.py, (probably some more)
documentation: (is fast anyway) doc/, src/, data/scripting/, data/tribes/, data/world/, data/txts/
The text was updated successfully, but these errors were encountered: