Ship window improvements (rebased) #6422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigned to tothxa |
bunnybot
added
bug
bunnybot
added
ci:success
bunnybot
added
ci:success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created on Fri Mar 29 02:17:34 CET 2024 by Tóth András (tothxa)
Type of change
Bugfix & New feature
Issue(s) closed
Replaces #6331 (rebased on master from protected/navalwarfare)
Fixes #6330
New behavior
SoldierPanelfor warships that are ready to fight, show onboard wares display (possibly with soldiers as generic cargo) while refittingPossible regressions
Ship window, wares and workers handling while refitting and soldier capacity is set to 0
Additional context
Expedition stopping is in separate commit(https://codeberg.org/tothxa/widelands/commit/afc16dd84f78a31c3e2aad88c0f3897c58c6c8b2), so it can be reverted easily if voted down. Otherwise icons should be more different probably. Either use scaled down portspace icon for construct port, or a smaller anchor in the stopping icon?