Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen Menus cannot relayout themselves #956

Closed
bunnybot opened this issue Sep 9, 2019 · 4 comments · Fixed by #4411
Closed

Fullscreen Menus cannot relayout themselves #956

bunnybot opened this issue Sep 9, 2019 · 4 comments · Fixed by #4411
Assignees
Labels
ui User interface
Milestone

Comments

@bunnybot
Copy link

bunnybot commented Sep 9, 2019

Now that we can change into fullscreen with 'f' everywhere it becomes apparent to the user that fullscreen menus never relayout themselves. The fix is very easy:

Either:

  • Each UI element must be hold on to as a member.
  • A layout() method puts them into the correct place. This will be called on resolution changes.

Or:

  • The menus are switched to using UI::Box which can already layout themselves. This will make working with them in the future also easier. This is more work.

See also: https://bugs.launchpad.net/widelands/+bug/1459529


Imported from Launchpad using lp2gh.

@bunnybot bunnybot added In Progress ui User interface labels Sep 9, 2019
@bunnybot
Copy link
Author

bunnybot commented Sep 9, 2019

(by sirver)
This has implications also for child windows. See bug 1398733.

@bunnybot
Copy link
Author

bunnybot commented Sep 9, 2019

(by franku)
I think SirVer meant this bug: bug 1598588 (duplicate to this one)

@bunnybot
Copy link
Author

bunnybot commented Sep 9, 2019

(by gunchleoc)
I am in favour of trying to move as much stuff as possible to Box - this will also allow for easy interface swapping for RTL languages.

@bunnybot bunnybot added this to the build21-rc1 milestone Sep 9, 2019
@gunchleoc gunchleoc removed the Medium label Sep 15, 2019
@gunchleoc gunchleoc self-assigned this Sep 15, 2019
@gunchleoc gunchleoc reopened this Sep 15, 2019
@gunchleoc
Copy link
Contributor

gunchleoc commented Sep 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui User interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants