Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs test: Secondary and Third Alternative Tool no longer reset to the first tool if you let go of the button #965

Open
bunnybot opened this issue Sep 9, 2019 · 3 comments
Labels
editor Editor-specific features testing Automated testing, unit tests, test suite.

Comments

@bunnybot
Copy link

bunnybot commented Sep 9, 2019

The bug has been fixed, but we still want a test.

SHIFT(hold): selects first alternative tool while pressing
ALT(hold): Selects second alternative tool while pressing

Holding the key do not work as described. You could release the key but the tool doesn't change to its normal state.

I.e.: In case of height tool, pressing shift will leave the tool to decrease height. You have to click on height tool again to get its normal state (increase height).


Imported from Launchpad using lp2gh.

@bunnybot bunnybot added Confirmed editor Editor-specific features labels Sep 9, 2019
@bunnybot
Copy link
Author

bunnybot commented Sep 9, 2019

(by sirver)
This regressed twice already. time to add a test.

@bunnybot
Copy link
Author

bunnybot commented Sep 9, 2019

(by gunchleoc)
While working on something else, I noticed that the SDL_KEYUP event isn't being handled, which is at the root of the problem. So, I made a quick branch. Not compiled or tested; so this bug is is still up for grabs until I get around to it.

@bunnybot
Copy link
Author

bunnybot commented Sep 9, 2019

(by gunchleoc)
OK, compiled and tested. This was indeed the problem, so I have made a merge request.

We still need to write a test for this though. I'll be happy to do so if somebody teaches me how.

@gunchleoc gunchleoc added launchpad_done testing Automated testing, unit tests, test suite. and removed Medium labels Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Editor-specific features testing Automated testing, unit tests, test suite.
Projects
None yet
Development

No branches or pull requests

2 participants