Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

New Slack Update 3.0.5 breaks this hack #43

Open
jimkiely-brainiacdevs opened this issue Jan 23, 2018 · 17 comments
Open

New Slack Update 3.0.5 breaks this hack #43

jimkiely-brainiacdevs opened this issue Jan 23, 2018 · 17 comments

Comments

@jimkiely-brainiacdevs
Copy link

The new slack 3.0.5 update breaks this hack in Window 10.

I have the readme code in the ssb-interop.js file. This worked for the past update, but not in 3.0.5. Anyone else having the same issue?

@Kredns
Copy link

Kredns commented Jan 23, 2018

Yep, I can confirm this as well on Linux[1]. @widget- have you been able to reproduce this also?

[1]: Fedora 27 - 4.14.13-300.fc27.x86_64

@spinegar
Copy link

On mac it seemed to revert my text color. Using a low contract theme made it very difficult to read. I ended up modifying the background css to be a bit lighter for now.

@yshinkarev
Copy link

Confirm. Xubuntu 16.04 amd64. Ignore theme, like nothing add to index.js

@nektobit
Copy link

Confirm, win 10

@david1602
Copy link

Have you tried using this?
I am definitely using 3.0.5 and it's working on Windows 10.

@yshinkarev
Copy link

@david1602 thanks, it's solve issue on my system.

@jer-tx
Copy link

jer-tx commented Feb 5, 2018

@david1602 that isn't working on 3.0.5 on OSX

Edit: I stand corrected. I missed the line about adding it to ssb-interop.js. I thought it was a replacement to what you add in index.js

@vladiibine
Copy link

For me, on ubuntu 16.04, with 3.0.5, putting the code in ssb-interop.js works.

It's still not nice if I am signed into 2 accounts, but that's another issue

@Azzuen1
Copy link

Azzuen1 commented Mar 4, 2018

I can confirm this as well

@antok87
Copy link

antok87 commented Mar 5, 2018

Dark theme is working ok but text on attachments is black and not readible, any idea how to fix that?

@Bterrell721
Copy link

Has anyone managed to create a fix for this theme that brings back full css control (text colors) and corrects sidebar overlap issues ("jump to" search overlaying "All Unreads" link)?

Currently using slack 3.1.0 beta desktop app on Windows 10. The update from @david1602 referenced above brings back functionality, but the text is stuck on grey and doesn't respect any font color choices.

@brantleyr
Copy link

I guess the CSS attributes and classes have changed a bit on the actual web app. You will need to apply new class overrides for things that you would like. For example to apply changes to the body text you will need new custom CSS in index.js.

div.c-message__content { color:#fff !important; } div.c-message__content span.c-message__body { color:#fff !important; } div.c-message__content div.c-message__content_header { color:#fff !important; } div.c-message__content div.c-message__content_header span.c-message__sender a.c-message__sender_link { color:#fff !important; } div.c-message__content div.c-message__content_header a.c-timestamp { color:#fff !important; } div.c-message__content div.c-message__content_header a.c-timestamp span.c-timestamp__label { color:#fff !important; }

Adding the above will make all the body text white. You can find out new classes or other classes you might need by going to the web app in your browser, right clicking what you want, inspecting source, then adding a CSS override as above.

@brantleyr
Copy link

Seems to be a duplicate of: https://github.com/widget-/slack-black-theme/issues/39

@bnayagrawal
Copy link

I am using slack on KDE. I applied this hack, It ain't working.

@seanpianka
Copy link

@bnayagrawal Confirmed that the updated changes to slack have broken this modification (applying changes to either index.js or ssb-interop.js still ends up w/ the chat background being white on white text).

@jrausch12
Copy link

@seanpianka Also confirming that as well on my end with 3.1.1

@d-fay
Copy link

d-fay commented Apr 18, 2018

@seanpianka and @jrausch12 this is because new CSS elements have been introduced that also need to be colored. The code you are adding to these files is not updated appropriately.The most recent comment on this issue addresses the problem.

Alternatively, I've been trying to keep this fork up-to-date with the latest fixes. It also addresses some other stylistic nuances that I haven't seen others address yet. Here it is: https://github.com/d-fay/slack-black-theme#installing-into-slack

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests