Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsInitallyExpanded for Addons #1172

Open
SlowDeepCoder opened this issue May 16, 2024 · 3 comments
Open

IsInitallyExpanded for Addons #1172

SlowDeepCoder opened this issue May 16, 2024 · 3 comments
Labels
p: core Related to `widgetbook` package t: feat New feature or request

Comments

@SlowDeepCoder
Copy link

Addons are super useful, however 90% of the times we don't really use them. So they end up being mostly in the way and being a strain to the eyes when trying to find the correct knobs. And we find ourselves restricitng how many addons we are using since if it's too many of them, we have to unexpand the addon list manually each time before we can continue testing with the knobs.

Having a property isAddonsInitallyExpanded for the Widgetbook would be amazing to solve this issue.

Here is an example of one of our simplest component, it has only one knob to select the color and the addons doesn't really provide anything useful for this component:
addonsScrolledUp

addonsScrolledDown
@YoussefRaafatNasry YoussefRaafatNasry added t: feat New feature or request p: core Related to `widgetbook` package labels May 16, 2024
@YoussefRaafatNasry
Copy link
Member

Hello @SlowDeepCoder 👋
Thanks for reporting this issue!

I agree that making the knobs more "primary" over addons can improve the UX.
What do you think about switching the accordion with tabs that have knobs as the default tab?

@YoussefRaafatNasry
Copy link
Member

YoussefRaafatNasry commented May 16, 2024

A similar change was proposed in #706 (without Knobs as default tab), but we decided not to proceed with it back then.
We will be re-evaluating this option and the one you've suggested.

@SlowDeepCoder
Copy link
Author

A similar change was proposed in #706 (without Knobs as default tab), but we decided not to proceed with it back then. We will be re-evaluating this option and the one you've suggested.

That's a great suggestion! I showed it to my collegaues as well and they all like the tabs, as long as is it would be possible to have the knobs as the default tab :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: core Related to `widgetbook` package t: feat New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants