Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade freezed and freezed_annotation to latest versions #174

Closed
zacherygentry opened this issue May 4, 2022 · 11 comments · Fixed by #183 or #184
Closed

Upgrade freezed and freezed_annotation to latest versions #174

zacherygentry opened this issue May 4, 2022 · 11 comments · Fixed by #183 or #184
Assignees
Labels
t: bug Something isn't working

Comments

@zacherygentry
Copy link

No description provided.

@jenshor
Copy link
Member

jenshor commented May 5, 2022

Thanks for raising this issue. We are working on it now 👍🏻

@jenshor jenshor added the t: bug Something isn't working label May 5, 2022
@jenshor jenshor self-assigned this May 5, 2022
@jenshor
Copy link
Member

jenshor commented May 5, 2022

We are currently blocked due to this issue: aloisdeniel/flutter_device_preview#180

@zacherygentry
Copy link
Author

We are currently blocked due to this issue: aloisdeniel/flutter_device_preview#180

Thanks for getting back so quickly. That repo seems to be somewhat inactive. Have you considered forking it and running your own so you can keep up with the latest versions?

@jonatandorozco
Copy link

https://github.com/aloisdeniel/flutter_device_preview
This repo has no activity in a time. There are pull requests opened and no response on issues.

image

Additionally there is a PR with the freezed package update waiting

image

Is there a possibility to fork the project to maintain this project up to date?

@jenshor
Copy link
Member

jenshor commented May 10, 2022

@jonorozcoc and @zacherygentry I think forking it is kind of a problem because public packages cannot contain git dependencies e.g.:

  device_frame:
    git:
      url: git://github.com/<repo>.git

But we can fork it in a way that we bake it into widgetbook which we will do for now. Maybe the package is getting more love from the initial contributor but i'm assuming he is busy doing other awesome stuff.

@jenshor
Copy link
Member

jenshor commented May 10, 2022

we've created a new package widgetbook_device_frame which is a fork of device_frame. For now we're not aiming to replace the package but we'll contact the original contributor of the package to get insights on what's planned for the future of device_frame so we can make a final decision.

@jenshor
Copy link
Member

jenshor commented May 10, 2022

@jonorozcoc and @zacherygentry please let us know if the fix works for you 👍🏻

@zacherygentry
Copy link
Author

@jenshor Almost! Just need the generator to also support freezed 2.0 to use it.

@jenshor
Copy link
Member

jenshor commented May 10, 2022

ah you're correct. I forgot to publish to pub.dev.

@jenshor
Copy link
Member

jenshor commented May 10, 2022

@zacherygentry just release widgetbook_generator in version 2.1.0.
If anything else comes up, let us know 👍🏻

@jonatandorozco
Copy link

Thanks @jenshor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: bug Something isn't working
Projects
None yet
3 participants