-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action Knob #538
Comments
Hey @patou. Thanks for opening this feature request. I already had a similar idea and we are looking forward to implementing this 👍🏻 |
Is this by any chance up for grabs (I know, it isn't labeled hacktoberfest but I made a promise to try and redeem myself)? My understanding is that there are two parts to this:
|
@geisterfurz007 This issue needs a lot of planning to be implemented properly. At the surface, it might look like an easy issue, but deep down there a lot of other aspects that need to be taken in consideration. One of the primary aspects will be "Widgetbook Cloud". Widgetbook OSS is rendered as a WebView inside the React app of Widgetbook Cloud, thus this WebView must notify the host app with all the actions being fired as well. We have solved this issue with Knobs by creating the "Fields API" that uses If you still wanna work on this feature, we will have to communicate more about it. |
I am still down! I am not sure what works best in terms of communication for you. Alternatively if you say that this needs to be fleshed out a bit more and think there is some other issue better suited for me, I'll happily pick that up too! I saw one about setting category and folder for Usecases for example that I would both love to work on and love to have in Widgetbook :) |
@geisterfurz007 I prefer if you worked on the category/folder issue first. It will be a good start to get yourself familiar with the code. Please add a comment there so I can assign it to you. |
Description
It can be a good new feature to have an action panel to log event from the onPressed of a button, for example.
It can be a function action with a name like this :
You can see a sample in storybook :
https://microsoft.github.io/vscode-webview-ui-toolkit/?path=/story/library-button--default
The text was updated successfully, but these errors were encountered: