Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildContext related Themes cannot be set or annotated #75

Closed
jenshor opened this issue Dec 10, 2021 · 0 comments · Fixed by #103
Closed

BuildContext related Themes cannot be set or annotated #75

jenshor opened this issue Dec 10, 2021 · 0 comments · Fixed by #103
Labels
t: feat New feature or request

Comments

@jenshor
Copy link
Member

jenshor commented Dec 10, 2021 •
edited

Some themes depend on BuildContext. The current properties require a ThemeData object but for Themes depending on BuildContext it would be beneficial if lightTheme and darkTheme properties would require a ThemeData Function(BuildContext context) type to build the theme.

Related packages:

  • widgetbook
  • widgetbook_generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved documentation regarding new and changed properties widgetbook/widgetbook
1 participant
@jenshor