Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image rendering on smaller viewports causes overflow issues. #7

Open
tylergeorges opened this issue Jun 16, 2023 · 2 comments
Open

Comments

@tylergeorges
Copy link
Contributor

Rendering messages with

  • Attachment images
  • Emotes
  • A name with a Bot/Server badge

all cause overflow issues on mobile devices when rendering with lists such as React Virtuoso, which causes blank spaces and jumping.

I'm sure its the images causing this, because when tested with channels that only have text content and no image attachments, it renders fine on mobile.

Video of issue:
https://github.com/widgetbot-io/message-renderer/assets/94828874/a6bffae4-96fb-45aa-836f-20f5a0e25147

@tylergeorges
Copy link
Contributor Author

Possible solution:

Scale attachment image sizes by a factor, and the factor is determined by the viewport

@inokawa
Copy link

inokawa commented Oct 20, 2023

Hello, I'm author of https://github.com/inokawa/virtua .
It has better jump suppression logic than react-virtuoso for iOS browsers and for resizes outside of viewport.
Check it out if you are interested in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants