Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging like vaex #527

Open
maartenbreddels opened this issue Feb 28, 2024 · 1 comment
Open

Make logging like vaex #527

maartenbreddels opened this issue Feb 28, 2024 · 1 comment

Comments

@maartenbreddels
Copy link
Contributor

Using vaex, it's very convenient to use logging, I propose we do something similar as in vaex:

But slightly modified (e.g. in vaex we always configure the logger framework, I think we should only do that if --log-config is not given):

Solara server using the CLI

  • For ultimate control, provide a config file using --log-config (like uvcorn) with this format https://docs.python.org/3/library/logging.config.html#logging-config-fileformat ✅ (this already works)
  • Quick configuration using e.g. SOLARA_DEBUG=solara.server SOLARA_INFO=solara.server.kernel_context which will configure the named logging with the right.
  • If --log-config is nog given, we configure the logger similar to vaex (preferably the rich formatted, and the special access handler for uvicorn)

Solara server mounted in FastAPI/Starlette

  • We should not do anything, except set the logging level (e.g. respond to SOLARA_DEUG and SOLARA_INFO ..l)

Jupyter environment

  • Same as previous.
@mariobuikhuizen
Copy link
Contributor

Would also be nice to be able to use an env var for log-config .. that's easier to set/change than the entrypoint in docker/docker-compose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants