Update enttec-open-usb-dmx.js #4
Conversation
|
|
||
| self.dev = new FTDI.FtdiDevice(device_id) | ||
| self.dev.open({ | ||
| 'baudrate': 115200 / 2, |
There was a problem hiding this comment.
I actually think that its clearer to inform folks that it is (realBaudrate / 2)
|
Hi, the first two comments are just minor things I noticed, if you want to keep them like this thats fine too. About the toHex() function please explain why it's needed (maybe add a comment) or remove it if we can do without it ;) |
|
Actually, the more I think about this, the more I think that this driver needs something drastic. Since the timing of the send loop is so critical, I think that the best thing to to is to fork a second node process off (cluster) and communicate universe changes with it via How would you feel about this module becoming that complex? |
|
If thats what it takes to get it running reliable sure. :D Remember that node has garbage collection which can cause latency you can't avoid even if running in a seperate process. Also not sure how much of that could be sidestepped with a native c/c++ module. In the end I think this will require some experimentation and testing until it's "good enough". |
|
That's exactly why the separate process is best. We create a loop with no scopes or variables, which should really limit garbage collection... or try anyway! |
|
sounds like a plan :) |
|
here are some updates
|
|
After this update, I'm going to start work on a smaller package just for the openDMX. I don't need animations, nor do I need the web server you provided. |
|
thanks for the contribution! I don't know what you have in mind for the smaller package, but if by chance it'll provide a reusable API I can add it as a dependency and use that directly. |
No description provided.